Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(remove50Missing): Clarify documentation regarding remove50Missing parameter #123

Merged
merged 1 commit into from
May 28, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented May 17, 2024

Motivation and Context

I got questions regarding the remove50Missing parameter, and then realized that the documentation is a bit hard to follow and doesn't define the feature well. Adjusted the parameter definition.

Changes

  • Adjusted the documentation regarding the remove50Missing parameter to be more clear on what it actually does.
  • Cleaned up documentation setup for MSstatsSummarize

Testing

  • Manuals have been updated with new information.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999
Copy link
Contributor Author

tonywu1999 commented May 17, 2024

Looking into the dry run errors right now. I think they're unrelated to my changes.

Fix: #124

@mstaniak
Copy link
Contributor

Thank @tonywu1999.
@devonjkohler I think we discussed this some time ago. Was the conclusion that it's better to actually remove this parameter? There's a question about it in the google group again, I'll double check the behavior of this and related options [counts].

@tonywu1999 tonywu1999 merged commit 3cb49a7 into devel May 28, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the docs-remove50 branch May 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants