Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indra): fetch networks from indra cogex and visualize with cytoscape #125

Closed
wants to merge 4 commits into from

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Jun 21, 2024

Motivation and Context

We want to integrate the statistical results of MSstats with prior literature extracted from INDRA. See this description for further information on INDRA.

Changes

  • Create 2 new functions to handle integration with INDRA. The first function fetches data from INDRA, filters and processes the response (e.g. collapsing duplicate edges), and provides dataframes of relationships. The second function visualizes it on Cytoscape.
  • Added testing framework with testthat. I believe we should start using testthat long term since it provides many additional functionalities compared to tinytest, such as mocking the output of functions. We don't have many unit tests in MSstats anyways (I think some of them aren't actually being executed), so I can migrate unit tests to testthat in the future.

Testing

  • Added a unit test verifying that the correct number of nodes and edges are returned given a mock response from INDRA and a mock dataset from the MSstats group comparison function.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999
Copy link
Contributor Author

Closing this PR in favor of Vitek-Lab/MSstatsBioNet#1

@tonywu1999 tonywu1999 closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants