Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(visualize): Change name of function visualizeSubnetwork to visualizeNetworks #10

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

tonywu1999
Copy link
Contributor

Motivation and Context

We want the visualization function to be clear on what it does. Since we don't really care about subnetworks for perturbations, the visualization function should be named in a way where it supports visualizing for both subnetworks and pathways.

Changes

  • Change name of function visualizeSubnetwork to visualizeNetworks

Testing

  • Existing unit tests pass

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (929df93) to head (31b9227).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel      #10   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files           3        3           
  Lines          97       97           
=======================================
  Hits           84       84           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonywu1999 tonywu1999 merged commit 87f13c3 into devel Jul 25, 2024
3 checks passed
@tonywu1999 tonywu1999 deleted the visualize-test branch August 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants