Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PD-converter): Enable spectrumFile to be used for run ID in PD converter #101

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

tonywu1999
Copy link
Contributor

Motivation and Context

Similar to this commit, but I'm pretty sure we should use SpectrumFile for the regular MSstats converter. Unit tests for MSstatsPTM seem to assume we use SpectrumFile.

Changes

  • Updated clean function to use SpectrumFile for the regular MSstats converter for PD.

Testing

  • Unit tests pass in MSstatsConvert, MSstats, MSstatsPTM. Previously, tests in MSstatsPTM were failing.
  • Note: I'm a little concerned about backwards compatibility here. People previously using FileID will end up having workflows breaking.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant