-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metamorpheus-converter): Add clean functionality of metamorpheus converter #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can merge this in if Matt doesn't have any changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rds rather than a text file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used an RDS file for unit testing purposes.
The output of the MSstatsImport function is an MSstatsMetamorpheusFiles object, and I wanted to use that object as the input of MSstatsClean for unit tests. At the same time, I wanted to test MSstatsClean independently from other functions. As a result, I saved the object as an RDS file and read the RDS file as input for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make things less confusing, I'll change the name of the RDS file to be something like "MSstatsMetamorpheusFilesObject.rds" to make it clear it's an object of class MSstatsMetamorpheusFiles and has nothing to do with the output of Metamorpheus directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only question is about the rds format.
Lets's move this rds file from raw_data to processed_data (or a similar name) and we're good to go |
…from annotation file
835b761
to
0199ea9
Compare
… converter (#83) * feat(metamorpheus-converter): Add clean functionality of metamorpheus converter * Modified metamorpheus annotation filename and removed techRep column from annotation file * Modify RDS filename to MSstatsMetamorpheusFilesObject for unit testing * create processed_data folder for testing
… converter (#83) * feat(metamorpheus-converter): Add clean functionality of metamorpheus converter * Modified metamorpheus annotation filename and removed techRep column from annotation file * Modify RDS filename to MSstatsMetamorpheusFilesObject for unit testing * create processed_data folder for testing
Description
As a part of this issue, users are requesting a converter from Metamorpheus to MSstatsPTM.
The first step is to create a converter from Metamorpheus to MSstats.
Changes
devtools::document()
Testing
Next Steps