Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metamorpheus-converter): Create converter for Metamorpheus to MSstatsPTM format #86

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Feb 21, 2024

Motivation and Context

As a part of this issue, we want to add a converter from Metamorpheus to MSstatsPTM format.

Changes

  • Added a new MetamorpheusToMSstatsPTMFormat function
  • Given there can be multiple modifications on a given peptide in Metamorpheus' output, we will initially set up the converter such that the user targets a specific modification, e.g. "Common Biological:Phosphorylation on S", using the parameter mod_id.
  • For now, we will neither remove rows containing a peptide with multiple modifications nor allow users to track multiple modifications (e.g. ProteinId_C_148_S_157). We can always add that feature in the future as an enhancement.

Testing

  • Added unit test that verifies that PTM and Protein output are produced with greater than 0 rows.
  • Ran R check and generated no new errors or warnings.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules - requires MSstatsConvert function MetamorpheusToMSstatsFormat to be published to Bioconductor.

@@ -1530,6 +1530,8 @@ MetamorpheusToMSstatsPTMFormat = function(input,
verbose,
log_file_path)

ptm_input = ptm_input[grepl(mod_id, ptm_input$PeptideSequence),]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ptm_input is data.table, the ptm_input$ part is not needed (so is ", " after it)

Copy link
Contributor Author

@tonywu1999 tonywu1999 Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look and ptm_input is a data.frame object, so removing the ptm_input$ part results in an error.

@tonywu1999 tonywu1999 changed the base branch from master to devel February 27, 2024 19:10
@tonywu1999 tonywu1999 merged commit 7ff61cd into devel Mar 4, 2024
@tonywu1999 tonywu1999 deleted the feature-metamorpheus-converter branch March 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants