Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(moderation): Adjust code to use limma legacy moderation code #84

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Nov 2, 2024

Motivation and Context

MSstatsTMT has a dependency on limma::squeezeVar and limma made this update to this function. I upgraded limma to the latest version and reproduced the same error.

In the context of assuming equal variance across proteins via variance moderation, limma adjusted how that variance is calculated if there are differing degrees of freedom across proteins (e.g. from differing amounts of missing values per protein). This means MSstatsTMT could have different moderated analysis results based on versioning.

Changes

  • As a quick fix, we can use the legacy code and unit tests pass.
  • In the short term, I'll stick with legacy = TRUE to maintain the current functionality and pass the unit test so that MSstatsTMT passes the check on bioconductor. 
  • Long term (pending): I'll make a future PR updating the tests and using the new version of squeezeVar.

Tests

  • Check succeeded locally with latest version of limma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant