Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand LP2PQuicTransport interface #28

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

backkem
Copy link
Collaborator

@backkem backkem commented Dec 22, 2023

This PR expands the LP2PQuicTransport support.

  • I added a receiver.ontransport to handle in coming transports.
  • I decided to make the LP2PConnection optional to establish a LP2PQuicTransport. Instead this is now done from the Request/Receiver. Naturally, all permission/authentication/grant steps remain relevant. However, this reduces boilerplate code when you're only interested in establishing a LP2PQuicTransport.
  • I removed the start() method of the LP2PQuicTransport to be more inline with the WebTransport interface design.

Follow-up discussion based on these changes:


Preview | Diff

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good design direction.

Btw. Happy Holidays! 🎄

@backkem backkem merged commit 1ce345b into WICG:main Dec 22, 2023
2 checks passed
@backkem backkem deleted the quic-transport branch December 22, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants