Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify event loop integration and prioritization #92

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

shaseley
Copy link
Collaborator

@shaseley shaseley commented May 30, 2024

  • Reword priority spec section to more closely match the recently added meta explainer
  • Add a note in the HTML event loop processing section to describe the intent of the Scheduler priorities wrt event loop integration, along with an example strategy (which ~= what we do in Chromium)

Preview | Diff

@shaseley shaseley requested a review from mmocny May 30, 2024 22:16
Copy link
Collaborator

@mmocny mmocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggests are attached, but the existing explanations are consistent and accurate, so I leave it to your judgement.

spec/patches.md Outdated Show resolved Hide resolved
spec/patches.md Outdated Show resolved Hide resolved
spec/scheduling-tasks.md Show resolved Hide resolved
spec/scheduling-tasks.md Outdated Show resolved Hide resolved
@shaseley shaseley requested a review from clelland June 3, 2024 18:59
spec/patches.md Show resolved Hide resolved
@shaseley
Copy link
Collaborator Author

shaseley commented Jun 5, 2024

Thanks @mmocny and @clelland!

@shaseley shaseley merged commit 054fcc5 into WICG:main Jun 5, 2024
2 checks passed
@shaseley shaseley deleted the spec-priority-cleanup branch June 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants