Expose Log Level without the need to import package logger as transitive dependency #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2023 12:43
…ackage logger on app side
quetool
requested review from
xzilja,
radeknovis,
kacperoak and
ignaciosantise
glitch-txs
approved these changes
Oct 16, 2023
Talhaali00
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before PR: If developer wanted to use
logLevel:parameter fromWeb3AppandWeb3Walletinstances used inCoremodule they had to import transitive dependencyimport 'package:logger/logger.dart';which is redundant.After PR: Developer will be able to use
logLevel:parameter with a new enum value calledLogLevelexported fromapis/utils/log_level.dart. No need to import any dependency, just uselogLevel: LogLevel.infoResolves # (issue)
How Has This Been Tested?
No tests needed as this doesn't involve any change in behaviors.
Due Dilligence