Improve gosec plugin validation and typing #262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves our handling of the JSON report from running gosec by defining the expected data model. Parsing and validation is handled by Pydantic, which was already a transient dependency but is now a direct dependency.
Unline the cwe library, cwe2 raises an InvalidCWEError exception when the CWE is not found. We provide the original default value in that case.
Fixes "attempted relative import with no known parent package" when run from the container.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves our handling of the JSON report from running gosec by defining the expected data model. Parsing and validation is handled by Pydantic, which was already a transient dependency but is now a direct
dependency.
Additionally, we have migrated from the unmaintained cwe library to the newer cwe2 library.
Motivation and Context
Makes the plugin behave more reliably if gosec produces unexpected results, which will make it easier to upgrade gosec in the future.
How Has This Been Tested?
TODO
Types of changes
Checklist