c2js - midi output and device select #204
Conversation
|
we should maybe rename hv_worklet_start.js to something like midi_utils.js - unless we'll be using it for other shared code as well. |
|
@chrisuehlinger hey we are wondering what the Can you give us some more info? (as it was almost being removed in this PR) |
First off, sorry for ghosting without totally finishing this work. Life got really hectic that summer very suddenly. I'd like to come back and check in on this at some point, make sure it builds against the most recent versions of these APIs and with the most recent version of emscripten. I may have some time in December or January, though I can't commit to anything 100%. Anyway, wrt this file, I think those are shims for some browser APIs that aren't present in the AudioWorklet and needed to be shimmed out so that other libraries wouldn't crash when loaded in an AudioWorklet. I'd recommend leaving that stuff in unless you've got a solid way to smoke test the outputs and make sure they don't crash. |
|
Thank you for the reply @chrisuehlinger ! Looking forward to your involvement again in the future :) |
|
Hm, seems to fail again because of flake8 complaining about the missing new line at the end in c2js, could it be this check was added after the last changes made in this file? As I completely restored it to the state before I touched it... |
|
No, these checks have been in place since forever. It seems you are not putting a proper newline here. |
|
@Reinissance I'll see if I can try this today :) |
Additions: