Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

Made required changes to Syncloop hackathon #756

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Susmita-Dey
Copy link
Contributor

@Susmita-Dey Susmita-Dey commented Aug 24, 2023

Fixes Issue

This PR fixes the following issues:

closes #issue-number

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

"New Features:

  • Added a new 'Resources' section to the navigation menu for enhanced user guidance.
  • Updated the 'SyncloopHackathon' object with a new judge, Rahul Khinchi, and provided his details.
  • Included links to the Syncloop YouTube channel and Udemy course in the 'takepart' section for additional resources.
  • Modified the 'Register' section's placement for better content flow.

Updates:

  • Updated the 'videoUrl' and 'liveUrl' properties with the latest URLs.
  • Revised the hackathon schedule with new dates.

Refactor:

  • Replaced the 'getDateTime' function with the 'getDate' function for improved date rendering.

Style:

  • Altered the text displayed for the 'Join now' button post-hackathon for clarity."

@coderabbitai
Copy link

coderabbitai bot commented Aug 24, 2023

Image description CodeRabbit

Walkthrough

This update brings changes to the hackathon page, including the addition of a new judge and resources section, updates to URLs and dates, and modifications to the display of date information. The "Judges" section has been removed from the navigation menu, and the "Join now" button text is updated based on the hackathon's end time.

Changes

File Summary
src/content/Hackathons/ParticularHackathonPageContent.js
src/content/Hackathons/syncloop.js
Removed "Judges" section from the navigation menu and added a new "Resources" section. Added a new judge to the judges array in the SyncloopHackathon object. Updated videoUrl, liveUrl, from, to, and winnerAnnouc properties. Modified the takepart section to include links to the Syncloop YouTube channel and Udemy course.
src/pages/PerticularhackathonPage.jsx Replaced getDateTime function with getDate for rendering date and time information. Updated "Join now" button text when current time is after the hackathon's end time. Moved "Register" section below the "Resources" section.

🐇💻

Code hopping down the bunny trail,

Updates here, they never fail.

Judges gone, but don't you fret,

Resources added, best update yet!

Dates and times, they're all in check,

Join now button, oh what the heck!

Celebrate these changes, do,

For they were made by coders true! 🎉🥕

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Actionable comments generated: 2

Commits Files that changed from the base of the PR and between 542e379 and c98728d commits.
Files ignored due to filter (1)
  • src/assets/hackathon/syncloop/judge.jpg
Files selected for processing (3)
  • src/content/Hackathons/ParticularHackathonPageContent.js (2 hunks)
  • src/content/Hackathons/syncloop.js (5 hunks)
  • src/pages/PerticularhackathonPage.jsx (4 hunks)
Files skipped from review due to trivial changes (1)
  • src/content/Hackathons/ParticularHackathonPageContent.js
LGTM comments (Suppressed): 1
src/pages/PerticularhackathonPage.jsx (1)
  • 325-329: The condition to render the Register component only when the current time is before the end time of the hackathon is a good practice. It prevents users from trying to register for an event that has already ended.
Additional comments (Suppressed): 7
src/content/Hackathons/syncloop.js (6)
  • 5-5: The import statement for the image of the new judge, Rahul Khinchi, has been added. Ensure that the image file judge.jpg exists in the specified path and is correctly named.

  • 22-24: The videoUrl and liveUrl properties have been updated with new URLs. Please verify that these URLs are correct and lead to the intended video and live stream respectively.

  • 108-111: A new judge, Rahul Khinchi, has been added to the judges array. Make sure that the provided details (name, description, twitter handle, and image) are accurate.

  • 119-120: The registration link for the Syncloop Platform has been updated. Please confirm that this URL is correct and leads to the intended registration page.

  • 133-134: The YouTube channel link for the Syncloop Platform has been updated. Please confirm that this URL is correct and leads to the intended YouTube channel.

  • 154-157: The hackathon dates (from, to, and winnerAnnouc) have been updated. Please ensure that these dates are correct and align with the planned schedule for the hackathon.

src/pages/PerticularhackathonPage.jsx (1)
  • 9-12: The function getDateTime has been replaced with getDate. Ensure that this change does not affect other parts of the codebase where getDateTime was used. Also, verify if the time information is not required in the context of this page. If it is, this change might lead to loss of important information.

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
  • A review comment is a comment on a diff or a file and not a comment on the PR itself.
  • You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

src/pages/PerticularhackathonPage.jsx Show resolved Hide resolved
src/pages/PerticularhackathonPage.jsx Show resolved Hide resolved
@Susmita-Dey Susmita-Dey merged commit 1eb4971 into WeMakeDevs:main Aug 24, 2023
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants