Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LZ22045-67] Cómo usuario quiero poder consultar el PDF mediante valida.one #9

Merged
merged 14 commits into from
Jul 17, 2023

Conversation

arnauZap
Copy link
Contributor

@arnauZap arnauZap commented Jul 13, 2023

Don't forget to add Jira issue related code to the title 😇

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix

Description

Added a new certification verification path called VERIFY_V2.
Changed the method of sending requests from fetch to axios.
Added error handling to send the request to the new verification route in case the original route fails.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Captura de pantalla 2023-07-17 a las 10 41 13 Captura de pantalla 2023-07-17 a las 10 41 30

[optional] What gif best describes this PR or how it makes you feel?

@arnauZap arnauZap changed the title Features/verify v2 [LZ22045-67] Cómo usuario quiero poder consultar el PDF mediante valida.one Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Warnings
⚠️ Coverage data had invalid formatting at path '/home/runner/work/validator/validator/coverage/coverage-summary.json'
Messages
📖 There aren't eslint errors in your code 🚀

Generated by 🚫 dangerJS against 0edbaa7

@Iraia26 Iraia26 requested a review from emenocal07 July 14, 2023 09:39
Arnau Zapata Delgado added 2 commits July 14, 2023 11:58
Copy link

@emenocal07 emenocal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por fa agrega tomas de pantalla del resultado de la tarea @arnauZap

@emenocal07 emenocal07 self-requested a review July 17, 2023 10:09
@arnauZap arnauZap merged commit 00df17f into master Jul 17, 2023
2 checks passed
@arnauZap arnauZap deleted the features/verify-v2 branch July 17, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants