Use Spans in cases where we can't infer them exactly - #9034
Merged
Conversation
tlively
approved these changes
Aug 21, 2026
| if (!cc) { | ||
| // Not comparing to a constant, so we can't infer anything exact, but might | ||
| // if we just need something we can prove, and if we know the type. | ||
| if (!exact && type) { |
Member
There was a problem hiding this comment.
Let's invert this and turn it into an early return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x < 10can be turned intoSpan{0,10}exactly, but we can actually infersomething from
x < yeven thoughyis unknown: x cannot be MAX_INT.That is, we can prove the Span must be contained in
Span{0, MAX_INT-1}even if we can't provide an exact span.
To use this, move the
getSpan()users out of the code that handlesconstant constraints and into where non-constant ones are handled. Then
just use
getProvenSpaninstead ofgetSpanwhere possible.This is important for certain loops (later PRs will depend on this).