feat: add policy to relevant key-based functions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Zak <richard@profian.com>
jedisct1
changed the title
jedisct1
changed the title
jedisct1
reviewed
Sep 22, 2022
| $policy_invalid | ||
|
|
||
| ;;; Not allowed by policy | ||
| $policy_unallowed |
There was a problem hiding this comment.
That seems to be redundant with $prohibited_operation
|
Not sure that this is it. In #58, there's a set of functions that don't inherit any existing handle. So we can't get back to the global context. A context (or "policy") should be added to them. This is a different thing than the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this about that you had in mind @npmccallum, @jedisct1?
Addresses #58.
Signed-off-by: Richard Zak richard@profian.com