Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get events for multiple users in a single request #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clarif
Copy link

@clarif clarif commented Sep 11, 2014

Hi,

Thanks for this very useful gem.

There is a little issue regarding user availability. The get_user_availability method takes as parameter an array of email addresses. That's needed when one wants to get availabilities of multiple users through a single request to the Exchange server. But from my understanding, this method only returns availability for the first user in the array.

This commit proposes a way to return availability for all users specified within the array. Regarding the result, since Exchange do no insert any user id within its response, availabilities are returned with a user value that contains the index of the user in the array passed as parameter.

It might probably be more efficient to parse directly the XML response from Exchange with Nokigiri (missing time to do so).

Thanks again for the library.
Fabrice.

@clarif clarif changed the title handle getting events for multiple users in a single request Get events for multiple users in a single request Sep 11, 2014
@zenchild
Copy link
Member

@clarif Sorry it's taken be so long to respond. If you can fix the spec to get that passing the rest looks good and I'll merge it in.

Base automatically changed from master to main February 3, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants