Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression on files with same-byte blocks #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunoanc
Copy link

@brunoanc brunoanc commented Jul 27, 2024

This PR is based on the one I submitted to the original ooz by rarten, intended to fix an issue with compressing some files. The text for that PR is below:

The line of code to skip over to the next block to compress runs twice when the AreAllBytesEqual test returns true, one on line 184 and another outside the if blocks on line 238. This causes issues when compressing files that have blocks of equal-byte data. This PR removes the extra line to fix compression for these files.

While I don't know if WolvenKit currently uses compression for any files that could cause this bug, I found this issue working on another project and thought the fix could be useful to you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant