Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

597: Refactor PyxformTestCase to use explicit keyword arguments #677

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

lindsay-stevens
Copy link
Contributor

@lindsay-stevens lindsay-stevens commented Dec 22, 2023

Closes #597

Also removed any test calls that use the default keyword value, if it seemed like that was not intentional. For example debug=False.

Why is this the best possible solution? Were any other approaches considered?

Could have maybe added a kwarg key check, but there was some of that already and it didn't catch everything.

What are the regression risks?

This is changing a test function used by many (most?) tests, so if the changes are not correct then pyxform won't be tested properly. Assuming they are correct, it would only be a problem if a fork or other library used PyxformTestCase.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run nosetests and verified all tests pass
  • run black pyxform tests to format code
  • verified that any code or assets from external sources are properly credited in comments

- also removed any test calls that use the default keyword value, if it
  seemed like that was not intentional. For example debug=False.
@lognaturel lognaturel merged commit 9ba1367 into XLSForm:master Jan 17, 2024
10 checks passed
@lindsay-stevens lindsay-stevens deleted the pyxform-597 branch January 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants