597: Refactor PyxformTestCase to use explicit keyword arguments #677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #597
Also removed any test calls that use the default keyword value, if it seemed like that was not intentional. For example debug=False.
Why is this the best possible solution? Were any other approaches considered?
Could have maybe added a kwarg key check, but there was some of that already and it didn't catch everything.
What are the regression risks?
This is changing a test function used by many (most?) tests, so if the changes are not correct then pyxform won't be tested properly. Assuming they are correct, it would only be a problem if a fork or other library used PyxformTestCase.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
tests
nosetests
and verified all tests passblack pyxform tests
to format code