Make tests have more realistic search() usage #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
commented
Jan 26, 2024
| @@ -1556,48 +1556,22 @@ def test_choice_name_containing_dash_output_itext(self): | |||
| class TestTranslationsSearchAppearance(PyxformTestCase): | |||
| """Translations behaviour with the search() appearance.""" | |||
|
|
|||
| def test_shared_choice_list(self): | |||
| """Should include translation for search() items, sharing the choice list""" | |||
There was a problem hiding this comment.
I couldn't understand the purpose of this test! I don't think there's any realistic case in which the search() configuration list would be used elsewhere. But also that's not what the test seemed to do (and maybe that's why the PR was marked as draft)
|
Replaced by #693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #690
Why is this the best possible solution? Were any other approaches considered?
This doesn't make any substantive change so I considered not doing it but I do think it's likely to help us in the future.
search(param.csv)uses a 1-element inline list to configure how it queriesparam.csv. It's only implemented in Collect and doesn't have a formal spec. I believe it gives an error if the supplied list has more than one element.What are the regression risks?
Test-only change so none.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
testsnosetestsand verified all tests passblack pyxform teststo format code