725: always produce entity forms with the offline entities spec version #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #725
Why is this the best possible solution? Were any other approaches considered?
What are the regression risks?
2024.1.0
so if these are provided to an older version of Central (or another spec-compliant server) then they will be rejected.offline
column is now undefined for theentities
sheet, so like other undefined columns it will now raise an error. Any forms that added theoffline
opt-in column will now need to remove it during their next form version update.Does this change require updates to documentation? If so, please file an issue here and include the link below.
Filed an issue to add the proposed offline version description to the spec: getodk/xforms-spec#319
Before submitting this PR, please make sure you have:
tests
python -m unittest
and verified all tests passruff format pyxform tests
andruff check pyxform tests
to lint code