Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions should not recommend vulnerable libpng libraries #947

Open
hawicz opened this issue Jan 22, 2024 · 1 comment
Open

Comments

@hawicz
Copy link

hawicz commented Jan 22, 2024

The install instructions (https://www.rapidwright.io/docs/Install.html#install) recommend installing old versions of the png library, namely libpng12. The problem with this is that there have been numerous vulnerabilities in libpng (https://www.cvedetails.com/vulnerability-list/vendor_id-7294/Libpng.html) and directing people to install such ancient, buggy versions seems rather irresponsible.

The instructions don't even refer to the most recent release of the 1.2 lineage (though even that is more than 7 years old at this point), and instead recommend manually installing a 1.2.54 package.

Where does the libpng dependency come in? Can it be updated to use a more modern version?

@clavin-xlnx
Copy link
Member

Thanks for bringing up this issue. The instructions for installing libpng are optional for the GUI use of RapidWright which is uncommon. I've just updated the documentation to denote that step as optional and also added a warning box to the install instructions. Most users do not use the GUI and therefore do not need to install libpng.

The libpng dependency is from Qt Jambi, a Java-based wrapper around Qt. RapidWright GUI applications were built on a fairly old version of it and there hasn't been a drop-in replacement upgrade for some time. There was some effort in #501, but it would require users additional steps to get it working. We will follow up on this option and leave this issue open for now until we can resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants