-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/validation steps #100
base: dev
Are you sure you want to change the base?
Conversation
Added files for validating finn-examples builds
Build verification by appending to Python sys.path and importing functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments. Will have another look later/tomorrow as needed
…y13/finn-examples into feature/validation_steps
Clean up verification build files
Looks good to me! |
platforms_to_build = zynq_platforms + alveo_platforms | ||
|
||
|
||
def custom_step_update_model(model, cfg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move this function to a central point, since it is used in multiple places. Either to finn or to qonnx, we can sync offline about this.
… validation steps
The PR enables optional verification for all finn-examples models. The verification is performed by running the model against a known input, then comparing the produced output against a known output to check if the values match, returning a success or fail depending on the result. The verification steps are run at various points throughout the build, after its corresponding build step has completed.
The verification can be enabled by setting the following environment variables:
Once these variables are set, the FINN build can be run and verification will be used within the build.
This PR depends on Xilinx/finn#1140