Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring linting inline with FINN repo #68

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Bring linting inline with FINN repo #68

merged 5 commits into from
Nov 22, 2023

Conversation

jmonks-amd
Copy link
Collaborator

@jmonks-amd jmonks-amd commented Nov 3, 2023

pre-commit is broken with the current config. This PR adopts the config from the FINN dev, cleans up necessary files and also adopts the pre-commit action from FINN dev.

@jmonks-amd jmonks-amd requested review from auphelia and mmrahorovic and removed request for auphelia November 3, 2023 10:23
Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in general good to me, thanks for aligning the linting with the finn repo!

The only thing that need to be addressed before merging is the copyright header in the pre-commit configuration.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@jmonks-amd jmonks-amd merged commit b1adbdb into dev Nov 22, 2023
1 check passed
@jmonks-amd jmonks-amd deleted the fix/linting branch November 22, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants