[FIX] Python Bindings DenseIntElementsAttr as Vector<? x Index> type #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttjost
reviewed
Mar 5, 2024
ttjost
reviewed
Mar 5, 2024
mgehre-amd
reviewed
Mar 5, 2024
mgehre-amd
approved these changes
Mar 5, 2024
|
Can you please change the commit title to something like |
This comment was marked as resolved.
This comment was marked as resolved.
cmcgirr-amd
force-pushed
the
christopher.FXML-4134_python_bindings_index_type
branch
3 times, most recently
from
4b1f345
to
f8ef350
Compare
Model the IndexType as size_t when converting to a python integer. This should follow the definition of the IndexType as system-dependent. This solves the following issue when for example an attribute is defined as: ``` denseattr = dense<[1, 2, 3, 4]> : vector<4xindex> ``` which is a valid DenseElementsAttr. The change will fix an access issue when reading the attribute in python. E.g. ``` DenseIntElementsAttr(op.attributes["denseattr"]) ``` Co-authored-by: Tiago Trevisan Jost <tiago.trevisanjost@amd.com> Co-authored-by: Matthias Gehre <matthias.gehre@amd.com>
cmcgirr-amd
force-pushed
the
christopher.FXML-4134_python_bindings_index_type
branch
from
f8ef350
to
37e4ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed when reading the attribute:
the python binding code would fail:
When converting the attribute to the dense representation. In C++ we can represent the DenseIntElementsAttr as a vector type with index elements. This PR attempts to resolve this issue for python bindings as well.