[FXML-4320] Restrict types that are valid in EmitC #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaAMD
force-pushed
the
tina.FXML-4320-restrict-emit-c-types
branch
from
80c0cbf
to
b3ff7dc
Compare
mgehre-amd
reviewed
Mar 18, 2024
mgehre-amd
reviewed
Mar 18, 2024
|
Do you want to already update ArithToEmitC here or in another PR? |
I am not sure. There are more dialects that convert to EmitC, maybe we should update all of them actually (in one go, in a separate PR probably)?😅 |
ok, let's try |
TinaAMD
force-pushed
the
tina.FXML-4320-restrict-emit-c-types
branch
from
0057b0b
to
0774e67
Compare
TinaAMD
changed the base branch from
feature/fused-ops
to
tina.FXML-4320-restrict-emit-c-float-int-types
TinaAMD
force-pushed
the
tina.FXML-4320-restrict-emit-c-types
branch
from
0774e67
to
b86f52f
Compare
Base automatically changed from
tina.FXML-4320-restrict-emit-c-float-int-types
to
feature/fused-ops
March 19, 2024 12:59
Use what is currently supported by the emitter to restrict the valid types of EmitC operations. Define three utility functions for valid types, such that they can be used to restrict the operations in the table gen as well as being available for reuse in dialect conversions.
TinaAMD
force-pushed
the
tina.FXML-4320-restrict-emit-c-types
branch
from
254a4bd
to
dd3575e
Compare
cferry-AMD
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use what is currently supported by the emitter to restrict the valid types of EmitC operations. Define utility function for valid types, such that they can be used to restrict the operations in the table gen as well as being available for reuse in dialect conversions.