arith-to-emitc: cmpf #142
Closed
arith-to-emitc: cmpf #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
commented
Mar 21, 2024
mgehre-amd
commented
Mar 21, 2024
* Support all kinds of unordered comparison * Translation could be smarter, e.g. unordered not equal conversion could use fewer ops
mgehre-amd
commented
Mar 25, 2024
| case arith::CmpFPredicate::UNO: { | ||
| // unordered, i.e. either operand is nan | ||
| unordered = true; | ||
| predicate = emitc::CmpPredicate::ne; |
There was a problem hiding this comment.
nit: seems a bit wasteful to emit a ne here when the check for IsUnordered is already enough. Maybe directly return createCheckIsUnordered here?
* Generate less ops for UNO * Add test for each supported cmpf op
|
Re-opening as #148 to make review easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts a few predicates of
arith.cmpfto emitc.I have to check closer on the
unordered or greater thanpredicate. From what I understand, C++>operator returns false when any operand is NaN, butunordered or greater thanshould return true when any operand is unordered (=NaN).