Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump with fixes to a4c47055 (26) #284

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Commits on Apr 4, 2024

  1. [mlir][linalg] Fix builder API usage in RegionBuilderHelper (llvm#8…

    …7451)
    
    Operations must be created with the supplied builder. Otherwise, the
    dialect conversion / greedy pattern rewrite driver can break.
    
    This commit fixes a crash in the dialect conversion:
    ```
    within split at llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-invalid.mlir:1 offset :8:8: error: failed to legalize operation 'tosa.add'
      %0 = tosa.add %1, %arg2 : (tensor<10x10xf32>, tensor<*xf32>) -> tensor<*xf32>
           ^
    within split at llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-invalid.mlir:1 offset :8:8: note: see current operation: %9 = "tosa.add"(%8, %arg2) : (tensor<10x10xf32>, tensor<*xf32>) -> tensor<*xf32>
    mlir-opt: llvm-project/mlir/include/mlir/IR/UseDefLists.h:198: mlir::IRObjectWithUseList<mlir::OpOperand>::~IRObjectWithUseList() [OperandType = mlir::OpOperand]: Assertion `use_empty() && "Cannot destroy a value that still has uses!"' failed.
    ```
    
    This commit is the proper fix for llvm#87297 (which was reverted).
    matthias-springer authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a4c4705 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge with fixes of a4c4705

    cferry-AMD committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2b0c7b1 View commit details
    Browse the repository at this point in the history