Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FXML-5071] Lower UB to EmitC #378

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[FXML-5071] Lower UB to EmitC #378

merged 5 commits into from
Sep 30, 2024

Conversation

cferry-AMD
Copy link
Collaborator

Using emitc.variable with a value of 0 to lower ub.poison.

josel-amd
josel-amd approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@josel-amd josel-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Discussed offline about setting a default value, but that's minor.

@cferry-AMD cferry-AMD marked this pull request as ready for review September 30, 2024 10:46
TinaAMD
TinaAMD approved these changes Sep 30, 2024
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mlir/test/Conversion/UBToEmitC/convert-ub-to-emitc.mlir Outdated Show resolved Hide resolved
@cferry-AMD cferry-AMD merged commit 69d08b3 into feature/fused-ops Sep 30, 2024
4 checks passed
@cferry-AMD cferry-AMD deleted the corentin.ub_lowering branch September 30, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaAMD TinaAMD TinaAMD approved these changes

@josel-amd josel-amd josel-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cferry-AMD @TinaAMD @josel-amd