Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbatim parsing to be unambiguous #385

Merged
merged 1 commit into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. Fix verbatim parsing to be unambiguous

    With the previous parsing, it would interpret
    ```
        emitc.verbatim "#endif // PL_USE_XRT"
        %4 = "emitc.constant"() <{value = 1 : i32}> : () -> i32
    ```
    as if
    ```
        emitc.verbatim "#endif // PL_USE_XRT" %4
        = "emitc.constant"() <{value = 1 : i32}> : () -> i32
    ```
    and then complain that it expected a `:` after the `%4`.
    
    Fix this by introducing a `args` keyword to distinguish the case where the veratim has args
    from the case where the next operation starts.
    mgehre-amd committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    95521c7 View commit details
    Browse the repository at this point in the history