Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement constant folding for tosa.slice #388

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: implement constant folding for tosa.slice #388

merged 2 commits into from
Oct 15, 2024

Conversation

ttjost
Copy link

@ttjost ttjost commented Oct 14, 2024 •
edited
Loading

Also validated with E2E tests.

@ttjost ttjost requested a review from ljfitz October 15, 2024 13:14
@ljfitz ljfitz removed their request for review October 15, 2024 13:31
flemairen6
flemairen6 approved these changes Oct 15, 2024
View reviewed changes
Copy link

@flemairen6 flemairen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttjost ttjost merged commit 08bb427 into feature/fused-ops Oct 15, 2024
4 checks passed
@ttjost ttjost deleted the tiagot.constant_folding_tosa_slice branch October 15, 2024 14:30
@ehsan-toosi ehsan-toosi removed their request for review October 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flemairen6 flemairen6 flemairen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttjost @flemairen6