[MLIR] [TOSA]: fix input index of tosa.pad folding. Improve lit tests. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Sep 8, 2023
ttjost
force-pushed
the
tiagot.fix_input_index_pad_folding
branch
from
8fa12ca
to
dc3e56c
Compare
mgehre-amd
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this issue when folding a large 3D tensor. The calculation of the index when the value ISN'T a pad must come from the
inputShape, and needs to be updated as well.Because our LIT tests didn't catch this (mostly due to using single values), I also updated them to multiple values so that we don't miss anything.
Also tested internally with some huge tensor.