Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FXML-2939] Fix rsqrt folder for bfloat16 #81

Merged

Conversation

TinaAMD
Copy link

@TinaAMD TinaAMD commented Sep 14, 2023

Make sure to use the correct APFloat semantics for bfloat16. Disable folding for float16 for now, due to uncertainty about precision requirements.

Make sure to use the correct APFloat semantics for bfloat16. Disable folding for float16 for now, due to uncertainty about precision requirements.
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mgehre-amd mgehre-amd merged commit dd37d22 into feature/fused-ops Sep 14, 2023
2 checks passed
@mgehre-amd mgehre-amd deleted the tina.FXML-2939-fix-bfloat-rsqrt-folding branch September 14, 2023 08:37
TinaAMD added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants