Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDLL: Parse integer literals into AttributeExpr #94

Merged
merged 1 commit into from
Feb 1, 2024
Merged

PDLL: Parse integer literals into AttributeExpr #94

merged 1 commit into from
Feb 1, 2024

Conversation

mgehre-amd
Copy link
Collaborator

@mgehre-amd mgehre-amd commented Jan 26, 2024 •
edited
Loading

This allows to write 10 : i32 to mean the same as attr<"10: i32">.

@mgehre-amd mgehre-amd requested review from ehsan-toosi and ttjost and removed request for ehsan-toosi January 26, 2024 19:20
ttjost
ttjost approved these changes Jan 26, 2024
View reviewed changes
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@mgehre-amd mgehre-amd merged commit 83a820c into feature/fused-ops Feb 1, 2024
2 checks passed
@mgehre-amd mgehre-amd deleted the matthias.integer_literals branch February 1, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttjost ttjost ttjost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgehre-amd @ttjost