[AMD-AIE] Fix ObjectFifoStatefulTransform to handle nested loops #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndraBisca
requested changes
Apr 3, 2024
Abhishek-Varma
force-pushed
the
jornt_nested_loop_fix
branch
from
b56ccfd
to
29aedeb
Compare
-- Currently ObjectFifoStatefulTransform pivots on wrong loop in case of nested loops and due to this the cloning operation in the `duplicateBlock` wrongly clones an ill-formed loop nest. -- This commit adds a fix to ObjectFifoStatefulTransform pass to handle nested loops. Signed-off-by: Jorn Tuyls <jorn.tuyls@amd.com>
jtuyls
force-pushed
the
jornt_nested_loop_fix
branch
from
29aedeb
to
300968b
Compare
AndraBisca
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Currently ObjectFifoStatefulTransform pivots on wrong loop in
case of nested loops and due to this the cloning operation
in the
duplicateBlockwrongly clones an ill-formed loop nest.-- This commit adds a fix to ObjectFifoStatefulTransform pass to handle
nested loops.
Signed-off-by: Jorn Tuyls jorn.tuyls@amd.com