Add generic aie array description paragraph #1191

denolf · 2024-04-08T23:03:47Z

Avoid relying on our mlir-aie dialect tutorials to introduce the AIE array architecture.
Should we start using the IRON acronym?

jgmelber · 2024-04-09T00:52:35Z

Do you intend to merge into main or asplos?

denolf · 2024-04-09T02:29:51Z

correct base to asplos

github-actions · 2024-04-09T15:46:42Z

Coverage Report

Created: 2024-04-10 14:27

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
AIE/Transforms/AIEObjectFifoRegisterProcess.cpp	100.00%	93.63%	96.77%	90.74%
AIE/Transforms/AIEObjectFifoStatefulTransform.cpp	100.00%	95.66%	94.44%	89.50%
AIEVec/TransformOps/AIEVecTransformOps.cpp	100.00%	98.44%	95.77%	76.92%
Totals	100.00%	95.98%	94.81%	88.42%

Generated by llvm-cov -- llvm version 14.0.0

fix typo

jackl-xilinx

Looks good! I edited a few items to improve phrasing and spelling.

denolf · 2024-04-10T14:23:42Z

Merged #1191

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

Signed-off-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: Javier Setoain <jsetoain@users.noreply.github.com> Co-authored-by: James Newling <james.newling@gmail.com> Co-authored-by: Maksim Levental <maksim.levental@gmail.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: erwei-xilinx <erweiw@xilinx.com> Co-authored-by: AndraBisca <andrab@amd.com> Started writing the objfifo intro tutorial Vectorize vec scalar (Xilinx#1135) Added new programming guide section placedholders (Xilinx#1138) [EXAMPLE] An element-wise add example (Xilinx#1148) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Lo <jack.lo@amd.com> Moved objfifo design example 1 to programming_guide sections 3. Started objectFifo programming guide Continue section 3 guide. ObjFifo guide: access patterns Add example to objFifo guide Update objfifo guide Separate section 3 of the guide into 3 subsections [ASPLOS] Weight expand asplos (Xilinx#1158) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Phil James-Roxby <pjr@amd.com> Reorganize subsections in section 3 of the guide. Updated sections 3a and 3b Pjr vector exp (Xilinx#1166) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [SOFTMAX] Single column rapid test (Xilinx#1168) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Vector softmax (Xilinx#1172) Co-authored-by: pjr <pjr@xilinx.com> [MERGE] This has gone horribly wrong, so fixing up in place Update exp.cc Merge resolved Added new programming guide section placedholders (Xilinx#1174) Swapped section-2 and section-3 (Xilinx#1177) Update section-1 and section-3 examples (Xilinx#1179) Update section-3 (Xilinx#1181) Reorganize tutorials and reference_designs to programming_examples (Xilinx#1182) Fix for mmult lit (Xilinx#1187) Revert "Fix for mmult lit" (Xilinx#1188) [ASPLOS][WIP] python host code example (Xilinx#1185) Extract arg parse from test.py (Xilinx#1192) Add finished write-up for sections 2a and 2b Add objectfifo bindings to quick references Update section2 subsection list [ASPLOS][WIP] initial version of asplos24 tutorial description (Xilinx#1184) Co-authored-by: Jack Lo <jack.lo@amd.com> Fix for lit tests (Xilinx#1189) Rename tutorials folder (Xilinx#1190) (Xilinx#1197) Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> [ASPLOS] Rename directories (Xilinx#1196) Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> Add section 2c. Update tiles in sections 2a and 2b. Add generic aie array description paragraph (Xilinx#1191) Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com> ReLU with tracing (Xilinx#1204) ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

avoid to close link to MLIR-AIE tutorials

5512459

denolf requested review from jamesroxbypb and jackl-xilinx April 8, 2024 23:03

denolf changed the base branch from main to asplos April 9, 2024 02:28

Merge branch 'asplos' into section1KristofUpdate

425aee0

denolf added 3 commits April 9, 2024 13:57

Merge branch 'asplos' into section1KristofUpdate

fe3a8a2

working on floating image

ec5e7e1

introduce aie-array

5028023

denolf marked this pull request as ready for review April 9, 2024 21:43

denolf added 3 commits April 9, 2024 16:01

Update aie2.py

e1b7ea5

fix typo

fix typos

71e9f12

added memTile and shimTile

5a67d3b

denolf requested a review from jgmelber April 9, 2024 22:59

Edited wording

823eeab

jackl-xilinx approved these changes Apr 10, 2024

View reviewed changes

Merge branch 'asplos' into section1KristofUpdate

b69d80b

denolf merged commit 48a8dfb into asplos Apr 10, 2024
53 of 54 checks passed

denolf deleted the section1KristofUpdate branch April 10, 2024 14:23

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 10, 2024

Add generic aie array description paragraph (Xilinx#1191)

21ef061

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

Add generic aie array description paragraph (Xilinx#1191)

ca82c22

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

Add generic aie array description paragraph (Xilinx#1191)

24b0572

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

Add generic aie array description paragraph (Xilinx#1191)

ed3d74e

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 22, 2024

Add generic aie array description paragraph (Xilinx#1191)

c9c8896

Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add generic aie array description paragraph #1191

Add generic aie array description paragraph #1191

denolf commented Apr 8, 2024

jgmelber commented Apr 9, 2024

denolf commented Apr 9, 2024

github-actions bot commented Apr 9, 2024 •

edited

Loading

jackl-xilinx left a comment

denolf commented Apr 10, 2024

Add generic aie array description paragraph #1191

Add generic aie array description paragraph #1191

Conversation

denolf commented Apr 8, 2024

jgmelber commented Apr 9, 2024

denolf commented Apr 9, 2024

github-actions bot commented Apr 9, 2024 • edited Loading

Coverage Report

Created: 2024-04-10 14:27

Generated by llvm-cov -- llvm version 14.0.0

jackl-xilinx left a comment

Choose a reason for hiding this comment

denolf commented Apr 10, 2024

github-actions bot commented Apr 9, 2024 •

edited

Loading