-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic aie array description paragraph #1191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
denolf
commented
Apr 8, 2024
- Avoid relying on our mlir-aie dialect tutorials to introduce the AIE array architecture.
- Should we start using the IRON acronym?
Do you intend to merge into main or asplos? |
correct base to asplos |
Coverage ReportCreated: 2024-04-10 14:27Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
jackl-xilinx
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I edited a few items to improve phrasing and spelling.
Merged #1191 |
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 10, 2024
Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: Javier Setoain <jsetoain@users.noreply.github.com> Co-authored-by: James Newling <james.newling@gmail.com> Co-authored-by: Maksim Levental <maksim.levental@gmail.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: erwei-xilinx <erweiw@xilinx.com> Co-authored-by: AndraBisca <andrab@amd.com> Started writing the objfifo intro tutorial Vectorize vec scalar (Xilinx#1135) Added new programming guide section placedholders (Xilinx#1138) [EXAMPLE] An element-wise add example (Xilinx#1148) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Lo <jack.lo@amd.com> Moved objfifo design example 1 to programming_guide sections 3. Started objectFifo programming guide Continue section 3 guide. ObjFifo guide: access patterns Add example to objFifo guide Update objfifo guide Separate section 3 of the guide into 3 subsections [ASPLOS] Weight expand asplos (Xilinx#1158) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Phil James-Roxby <pjr@amd.com> Reorganize subsections in section 3 of the guide. Updated sections 3a and 3b Pjr vector exp (Xilinx#1166) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [SOFTMAX] Single column rapid test (Xilinx#1168) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Vector softmax (Xilinx#1172) Co-authored-by: pjr <pjr@xilinx.com> [MERGE] This has gone horribly wrong, so fixing up in place Update exp.cc Merge resolved Added new programming guide section placedholders (Xilinx#1174) Swapped section-2 and section-3 (Xilinx#1177) Update section-1 and section-3 examples (Xilinx#1179) Update section-3 (Xilinx#1181) Reorganize tutorials and reference_designs to programming_examples (Xilinx#1182) Fix for mmult lit (Xilinx#1187) Revert "Fix for mmult lit" (Xilinx#1188) [ASPLOS][WIP] python host code example (Xilinx#1185) Extract arg parse from test.py (Xilinx#1192) Add finished write-up for sections 2a and 2b Add objectfifo bindings to quick references Update section2 subsection list [ASPLOS][WIP] initial version of asplos24 tutorial description (Xilinx#1184) Co-authored-by: Jack Lo <jack.lo@amd.com> Fix for lit tests (Xilinx#1189) Rename tutorials folder (Xilinx#1190) (Xilinx#1197) Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> [ASPLOS] Rename directories (Xilinx#1196) Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> Add section 2c. Update tiles in sections 2a and 2b. Add generic aie array description paragraph (Xilinx#1191) Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com> ReLU with tracing (Xilinx#1204) ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: Javier Setoain <jsetoain@users.noreply.github.com> Co-authored-by: James Newling <james.newling@gmail.com> Co-authored-by: Maksim Levental <maksim.levental@gmail.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: erwei-xilinx <erweiw@xilinx.com> Co-authored-by: AndraBisca <andrab@amd.com> Started writing the objfifo intro tutorial Vectorize vec scalar (Xilinx#1135) Added new programming guide section placedholders (Xilinx#1138) [EXAMPLE] An element-wise add example (Xilinx#1148) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Lo <jack.lo@amd.com> Moved objfifo design example 1 to programming_guide sections 3. Started objectFifo programming guide Continue section 3 guide. ObjFifo guide: access patterns Add example to objFifo guide Update objfifo guide Separate section 3 of the guide into 3 subsections [ASPLOS] Weight expand asplos (Xilinx#1158) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Phil James-Roxby <pjr@amd.com> Reorganize subsections in section 3 of the guide. Updated sections 3a and 3b Pjr vector exp (Xilinx#1166) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [SOFTMAX] Single column rapid test (Xilinx#1168) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Vector softmax (Xilinx#1172) Co-authored-by: pjr <pjr@xilinx.com> [MERGE] This has gone horribly wrong, so fixing up in place Update exp.cc Merge resolved Added new programming guide section placedholders (Xilinx#1174) Swapped section-2 and section-3 (Xilinx#1177) Update section-1 and section-3 examples (Xilinx#1179) Update section-3 (Xilinx#1181) Reorganize tutorials and reference_designs to programming_examples (Xilinx#1182) Fix for mmult lit (Xilinx#1187) Revert "Fix for mmult lit" (Xilinx#1188) [ASPLOS][WIP] python host code example (Xilinx#1185) Extract arg parse from test.py (Xilinx#1192) Add finished write-up for sections 2a and 2b Add objectfifo bindings to quick references Update section2 subsection list [ASPLOS][WIP] initial version of asplos24 tutorial description (Xilinx#1184) Co-authored-by: Jack Lo <jack.lo@amd.com> Fix for lit tests (Xilinx#1189) Rename tutorials folder (Xilinx#1190) (Xilinx#1197) Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> [ASPLOS] Rename directories (Xilinx#1196) Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> Add section 2c. Update tiles in sections 2a and 2b. Add generic aie array description paragraph (Xilinx#1191) Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com> ReLU with tracing (Xilinx#1204) ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: Javier Setoain <jsetoain@users.noreply.github.com> Co-authored-by: James Newling <james.newling@gmail.com> Co-authored-by: Maksim Levental <maksim.levental@gmail.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: erwei-xilinx <erweiw@xilinx.com> Co-authored-by: AndraBisca <andrab@amd.com> Started writing the objfifo intro tutorial Vectorize vec scalar (Xilinx#1135) Added new programming guide section placedholders (Xilinx#1138) [EXAMPLE] An element-wise add example (Xilinx#1148) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Lo <jack.lo@amd.com> Moved objfifo design example 1 to programming_guide sections 3. Started objectFifo programming guide Continue section 3 guide. ObjFifo guide: access patterns Add example to objFifo guide Update objfifo guide Separate section 3 of the guide into 3 subsections [ASPLOS] Weight expand asplos (Xilinx#1158) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Phil James-Roxby <pjr@amd.com> Reorganize subsections in section 3 of the guide. Updated sections 3a and 3b Pjr vector exp (Xilinx#1166) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [SOFTMAX] Single column rapid test (Xilinx#1168) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Vector softmax (Xilinx#1172) Co-authored-by: pjr <pjr@xilinx.com> [MERGE] This has gone horribly wrong, so fixing up in place Update exp.cc Merge resolved Added new programming guide section placedholders (Xilinx#1174) Swapped section-2 and section-3 (Xilinx#1177) Update section-1 and section-3 examples (Xilinx#1179) Update section-3 (Xilinx#1181) Reorganize tutorials and reference_designs to programming_examples (Xilinx#1182) Fix for mmult lit (Xilinx#1187) Revert "Fix for mmult lit" (Xilinx#1188) [ASPLOS][WIP] python host code example (Xilinx#1185) Extract arg parse from test.py (Xilinx#1192) Add finished write-up for sections 2a and 2b Add objectfifo bindings to quick references Update section2 subsection list [ASPLOS][WIP] initial version of asplos24 tutorial description (Xilinx#1184) Co-authored-by: Jack Lo <jack.lo@amd.com> Fix for lit tests (Xilinx#1189) Rename tutorials folder (Xilinx#1190) (Xilinx#1197) Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> [ASPLOS] Rename directories (Xilinx#1196) Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> Add section 2c. Update tiles in sections 2a and 2b. Add generic aie array description paragraph (Xilinx#1191) Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com> ReLU with tracing (Xilinx#1204) ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)
fifield
pushed a commit
to fifield/mlir-aie
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.