[ASPLOS][WIP] Passthrough kernel in basic examples #1216

denolf · 2024-04-10T20:55:32Z

No description provided.

aie_kernels/aie_generic/passThrough.cc

programming_examples/basic/passthrough_kernel/test.cpp

programming_examples/basic/passthrough_dmas/aie2.py

programming_examples/basic/passthrough_kernel/aie2.py

programming_examples/basic/passthrough_kernel/test.cpp

programming_examples/basic/passthrough_kernel/aie2.py

github-actions · 2024-04-10T23:16:34Z

Coverage Report

Created: 2024-04-11 21:18

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
Conversion/AIEVecToLLVM/AIEVecToLLVM.cpp	82.05%	87.48%	74.30%	60.16%
Dialect/AIE/Transforms/AIEObjectFifoRegisterProcess.cpp	100.00%	93.63%	96.77%	90.74%
Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp	100.00%	95.66%	94.44%	89.50%
Dialect/AIEVec/TransformOps/AIEVecTransformOps.cpp	100.00%	98.44%	95.77%	76.92%
Dialect/AIEX/Transforms/AIEDmaToIpu.cpp	100.00%	93.21%	88.75%	76.79%
Totals	93.20%	93.38%	89.67%	82.55%

Generated by llvm-cov -- llvm version 14.0.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

AndraBisca

This looks good! I can point to the passthrough_kernel from the programming guide since it contains a very simple design with L3 to L1 and back data movement.

github-actions · 2024-04-11T21:02:56Z

programming_examples/basic/passthrough_kernel/test.cpp

+#include <iostream>
+#include <sstream>
+
+#include "xrt/xrt_bo.h"


[clang-format] _{reported by reviewdog 🐶}

Suggested change

#include "xrt/xrt_bo.h"

github-actions · 2024-04-11T21:02:56Z

programming_examples/basic/passthrough_kernel/test.cpp

+
+#include "xrt/xrt_bo.h"
+#include "test_utils.h"
+


[clang-format] _{reported by reviewdog 🐶}

Suggested change

#include "xrt/xrt_bo.h"

github-actions · 2024-04-11T21:02:56Z

programming_examples/basic/passthrough_kernel/test.cpp

+  test_utils::init_xrt_load_kernel(device, kernel, verbosity, vm["xclbin"].as<std::string>(),
+                    vm["kernel"].as<std::string>());


[clang-format] _{reported by reviewdog 🐶}

Suggested change

test_utils::init_xrt_load_kernel(device, kernel, verbosity, vm["xclbin"].as<std::string>(),

vm["kernel"].as<std::string>());

test_utils::init_xrt_load_kernel(device, kernel, verbosity,

vm["xclbin"].as<std::string>(),

vm["kernel"].as<std::string>());

github-actions · 2024-04-11T21:02:56Z

runtime_lib/test_lib/test_utils.h

@@ -19,6 +19,7 @@
 #include <sstream>
 #include <string>
 #include <vector>
+#include <iomanip>


[clang-format] _{reported by reviewdog 🐶}

Suggested change

#include <iomanip>

github-actions · 2024-04-11T21:16:08Z

aie_kernels/aie_generic/passThrough.cc

-      // out += N;
-    }
+    chess_prepare_for_pipelining chess_loop_range(6, ) { *outPtr++ = *inPtr++; }
+


[clang-format] _{reported by reviewdog 🐶}

Suggested change

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Signed-off-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: Javier Setoain <jsetoain@users.noreply.github.com> Co-authored-by: James Newling <james.newling@gmail.com> Co-authored-by: Maksim Levental <maksim.levental@gmail.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Abhishek Varma <abhvarma@amd.com> Co-authored-by: erwei-xilinx <erweiw@xilinx.com> Co-authored-by: AndraBisca <andrab@amd.com> Started writing the objfifo intro tutorial Vectorize vec scalar (Xilinx#1135) Added new programming guide section placedholders (Xilinx#1138) [EXAMPLE] An element-wise add example (Xilinx#1148) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Lo <jack.lo@amd.com> Moved objfifo design example 1 to programming_guide sections 3. Started objectFifo programming guide Continue section 3 guide. ObjFifo guide: access patterns Add example to objFifo guide Update objfifo guide Separate section 3 of the guide into 3 subsections [ASPLOS] Weight expand asplos (Xilinx#1158) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Phil James-Roxby <pjr@amd.com> Reorganize subsections in section 3 of the guide. Updated sections 3a and 3b Pjr vector exp (Xilinx#1166) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [SOFTMAX] Single column rapid test (Xilinx#1168) Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Vector softmax (Xilinx#1172) Co-authored-by: pjr <pjr@xilinx.com> [MERGE] This has gone horribly wrong, so fixing up in place Update exp.cc Merge resolved Added new programming guide section placedholders (Xilinx#1174) Swapped section-2 and section-3 (Xilinx#1177) Update section-1 and section-3 examples (Xilinx#1179) Update section-3 (Xilinx#1181) Reorganize tutorials and reference_designs to programming_examples (Xilinx#1182) Fix for mmult lit (Xilinx#1187) Revert "Fix for mmult lit" (Xilinx#1188) [ASPLOS][WIP] python host code example (Xilinx#1185) Extract arg parse from test.py (Xilinx#1192) Add finished write-up for sections 2a and 2b Add objectfifo bindings to quick references Update section2 subsection list [ASPLOS][WIP] initial version of asplos24 tutorial description (Xilinx#1184) Co-authored-by: Jack Lo <jack.lo@amd.com> Fix for lit tests (Xilinx#1189) Rename tutorials folder (Xilinx#1190) (Xilinx#1197) Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> [ASPLOS] Rename directories (Xilinx#1196) Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Co-authored-by: AndraBisca <andrab@amd.com> Co-authored-by: Jack Lo <36210336+jackl-xilinx@users.noreply.github.com> Add section 2c. Update tiles in sections 2a and 2b. Add generic aie array description paragraph (Xilinx#1191) Co-authored-by: Joseph Melber <jgmelber@gmail.com> Co-authored-by: Jack Lo <jack.lo@amd.com> ReLU with tracing (Xilinx#1204) ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)

ReLU example with tracing Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Joseph Melber <jgmelber@gmail.com> Ml eltwise add and mul (Xilinx#1207) Move around of the eltwise add (put it in ml) and a new eltwise mul kernel Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: Jeff Fifield <jeff.fifield@amd.com> Moved test_lib to runtime_lib/test_lib for now Pjr reduce (Xilinx#1222) Reduce programming examples Co-authored-by: pjr <pjr@xilinx.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix paths run.lit passthrough _kernel (Xilinx#1225) Fixed CMakeLists.txt reference to test_utils.h (Xilinx#1223) Minor CMakeLists.txt and Makefile fixes for programming_examples (Xilinx#1227)

basic passthrough_kernel

cd2345a

denolf changed the base branch from main to asplos April 10, 2024 20:55

denolf requested review from jackl-xilinx and jamesroxbypb April 10, 2024 20:56

denolf added 2 commits April 10, 2024 17:03

rename and clean up

b17f178

Merge branch 'asplos' into passthroughKernel

ab84b08

github-actions bot reviewed Apr 10, 2024

View reviewed changes

fix passThrough with images

61511b2

denolf and others added 3 commits April 10, 2024 17:31

Apply suggestions from code review

2f7ce0e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

apply clang-format patch

a9a77a7

fix format with black

ec069ab

denolf marked this pull request as ready for review April 10, 2024 23:55

denolf requested a review from AndraBisca April 11, 2024 14:18

AndraBisca approved these changes Apr 11, 2024

View reviewed changes

merge asplos

e96c54c

github-actions bot reviewed Apr 11, 2024

View reviewed changes

chop in 4 sub tensors and add events to kernel

509b2c1

github-actions bot reviewed Apr 11, 2024

View reviewed changes

jackl-xilinx merged commit 73440d7 into asplos Apr 11, 2024
51 of 54 checks passed

jackl-xilinx deleted the passthroughKernel branch April 11, 2024 22:38

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

[ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216)

d85fa49

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

[ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216)

d84b190

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

[ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216)

0300869

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 12, 2024

[ASPLOS][WIP] Passthrough kernel in basic examples (Xilinx#1216)

fb7779d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASPLOS][WIP] Passthrough kernel in basic examples #1216

[ASPLOS][WIP] Passthrough kernel in basic examples #1216

denolf commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 •

edited

Loading

AndraBisca left a comment

github-actions bot Apr 11, 2024

github-actions bot Apr 11, 2024

github-actions bot Apr 11, 2024

github-actions bot Apr 11, 2024

github-actions bot Apr 11, 2024

		test_utils::init_xrt_load_kernel(device, kernel, verbosity, vm["xclbin"].as<std::string>(),
		vm["kernel"].as<std::string>());

[ASPLOS][WIP] Passthrough kernel in basic examples #1216

[ASPLOS][WIP] Passthrough kernel in basic examples #1216

Conversation

denolf commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 • edited Loading

Coverage Report

Created: 2024-04-11 21:18

Generated by llvm-cov -- llvm version 14.0.0

AndraBisca left a comment

Choose a reason for hiding this comment

github-actions bot Apr 11, 2024

Choose a reason for hiding this comment

github-actions bot Apr 11, 2024

Choose a reason for hiding this comment

github-actions bot Apr 11, 2024

Choose a reason for hiding this comment

github-actions bot Apr 11, 2024

Choose a reason for hiding this comment

github-actions bot Apr 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 10, 2024 •

edited

Loading