Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASPLOS] bring back run_on_ipu #1272

Merged
merged 5 commits into from
Apr 17, 2024
Merged

[ASPLOS] bring back run_on_ipu #1272

merged 5 commits into from
Apr 17, 2024

Conversation

denolf
Copy link
Collaborator

@denolf denolf commented Apr 16, 2024

more run.lit in need of having run_on_ipu again

@denolf denolf requested a review from fifield April 16, 2024 23:47
@denolf denolf changed the title bring back run_on_ipu [ASPLOS] bring back run_on_ipu Apr 16, 2024
@denolf denolf mentioned this pull request Apr 16, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Coverage Report

Created: 2024-04-17 15:45

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
Conversion/AIEVecToLLVM/AIEVecToLLVM.cpp 82.05% 87.48% 74.30% 60.16%
Dialect/AIE/Transforms/AIEObjectFifoRegisterProcess.cpp 100.00% 93.63% 96.77% 90.74%
Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 95.66% 94.44% 89.50%
Dialect/AIEVec/TransformOps/AIEVecTransformOps.cpp 100.00% 98.44% 95.77% 76.92%
Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp 70.87% 63.72% 49.70% 41.68%
Dialect/AIEX/IR/AIEXDialect.cpp 100.00% 85.09% 84.44% 75.00%
Dialect/AIEX/Transforms/AIEDmaToIpu.cpp 100.00% 93.21% 88.75% 76.79%
Dialect/AIEX/Transforms/AIEXToStandard.cpp 75.00% 75.00% 66.67% 50.00%
Totals 81.71% 78.53% 65.98% 58.23%
Generated by llvm-cov -- llvm version 14.0.0

@makslevental
Copy link
Contributor

Not sure why this was changed (not tracking this branch) but utils/run_on_ipu.sh already has that env variable:

mlir-aie/utils/run_on_ipu.sh

Line 7 in c1ec412

export XRT_HACK_UNSECURE_LOADING_XCLBIN=1

@denolf denolf merged commit 9ad4e79 into asplos Apr 17, 2024
17 of 18 checks passed
@denolf denolf deleted the fixRunIPU branch April 17, 2024 15:33
fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 17, 2024
@denolf @fifield
[ASPLOS] bring back run_on_ipu (Xilinx#1272)
9ae7a1c
fifield pushed a commit that referenced this pull request Apr 17, 2024
@denolf @fifield
[ASPLOS] bring back run_on_ipu (#1272)
4209b01
singagan pushed a commit that referenced this pull request Apr 18, 2024
@denolf @singagan
[ASPLOS] bring back run_on_ipu (#1272)
095833d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield Awaiting requested review from fifield

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denolf @makslevental