Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aievec] to-llvm flow for aievec.ext op #1481

Merged
merged 6 commits into from
May 14, 2024
Merged

[aievec] to-llvm flow for aievec.ext op #1481

merged 6 commits into from
May 14, 2024

Conversation

jamestcl-amd
Copy link
Collaborator

This PR add the support for aievec.ext op going through the to-llvm flow.

Changes:

  • Add ext intrinsic ops to XLLVM dialect.
  • Add aievec-to-llvm conversion pattern/tests for the aievec.ext op.
  • Add test for translating to external llvm.

jsetoain
jsetoain approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@jsetoain jsetoain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the typo in the CHECK line, everything looks good.

@jamestcl-amd jamestcl-amd added this pull request to the merge queue May 14, 2024
Merged via the queue into Xilinx:main with commit 7f43bb3 May 14, 2024
55 checks passed
@jamestcl-amd jamestcl-amd deleted the aievec_ext_llvm branch May 14, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsetoain jsetoain jsetoain approved these changes

@david-vc david-vc Awaiting requested review from david-vc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamestcl-amd @jsetoain