Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aievec] to-llvm flow for aievec.min op #1519

Merged
merged 6 commits into from
May 30, 2024
Merged

[aievec] to-llvm flow for aievec.min op #1519

merged 6 commits into from
May 30, 2024

Conversation

jamestcl-amd
Copy link
Collaborator

This PR add the support for aievec.min op going through the to-llvm flow.

Changes:

  • Add vmin intrinsic ops to XLLVM dialect.
  • Add aievec-to-llvm conversion pattern/tests for the aievec.min op.
  • Add lit test for translating to external llvm.

david-vc
david-vc reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@david-vc david-vc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow on my comment about the case with 64 lanes.

include/aie/Dialect/XLLVM/IR/XLLVMAIE2IntrOps.td Outdated Show resolved Hide resolved
lib/Conversion/AIEVecToLLVM/AIEVecToLLVM.cpp Show resolved Hide resolved
david-vc
david-vc approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@david-vc david-vc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamestcl-amd jamestcl-amd added this pull request to the merge queue May 30, 2024
Merged via the queue into Xilinx:main with commit 5524a8d May 30, 2024
51 checks passed
@jamestcl-amd jamestcl-amd deleted the aievec_min_llvm branch May 30, 2024 18:58
singagan pushed a commit that referenced this pull request Jun 5, 2024
@jamestcl-amd @singagan
[aievec] to-llvm flow for aievec.min op (#1519)
b99db03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-vc david-vc david-vc approved these changes

@jsetoain jsetoain Awaiting requested review from jsetoain jsetoain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamestcl-amd @david-vc