Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move conditionals to target model #1537

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Move conditionals to target model #1537

merged 3 commits into from
Jun 6, 2024

Conversation

stephenneuendorffer
Copy link
Collaborator

No description provided.

fifield
fifield approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have overlapping changes in #1540, to add row and col shift to targetmodel, which are admittedly unrelated changes over there. I'll rebase that on this after this lands.

@fifield
Copy link
Collaborator

fifield commented Jun 6, 2024

We also need to update include/aie-c/TargetModel.h, lib/CAPI/TargetModel.cpp and python/AIEMLIRModule.cpp to get python support.

@stephenneuendorffer stephenneuendorffer added this pull request to the merge queue Jun 6, 2024
Merged via the queue into Xilinx:main with commit 65d2e7b Jun 6, 2024
51 checks passed
@stephenneuendorffer stephenneuendorffer deleted the target branch June 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield fifield approved these changes

@makslevental makslevental Awaiting requested review from makslevental

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenneuendorffer @fifield