[ObjectFifoStatefulTransform] Reuse mlir::loopUnrollByFactor instead of custom function #1545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an error with a
reinterpret_cast
operation insideaie.core
, operating on anaie.objectfifo.subview.access
operation. The cloned reinterpret cast would be invalid after theunrollForLoops
method was called. I debugged this a bit and it seemed operands were set incorrectly in some cases, however, instead of fixing the existing method I replaced it with the upstreammlir::loopUnrollByFactor
method as it would be better to reuse that one instead I think. With this change thereinterpret_cast
error got resolved as well.