Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjectFifoStatefulTransform] Reuse mlir::loopUnrollByFactor instead of custom function #1545

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Jun 10, 2024

I encountered an error with a reinterpret_cast operation inside aie.core, operating on an aie.objectfifo.subview.access operation. The cloned reinterpret cast would be invalid after the unrollForLoops method was called. I debugged this a bit and it seemed operands were set incorrectly in some cases, however, instead of fixing the existing method I replaced it with the upstream mlir::loopUnrollByFactor method as it would be better to reuse that one instead I think. With this change the reinterpret_cast error got resolved as well.

Copy link
Collaborator

@AndraBisca AndraBisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I meant to use this at some point during the original design of the object FIFO but couldn't figure out how to do it then. I'm happy to replace the custom unrolling if it works with all of our designs! Thank you!

@jtuyls jtuyls added this pull request to the merge queue Jun 10, 2024
Merged via the queue into Xilinx:main with commit 7635c9e Jun 10, 2024
51 checks passed
@jtuyls jtuyls deleted the stateful-transform-reuse-loop-unroll branch June 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants