Added mlir->LLVMIR conversion for tanh op using LUT #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2024 12:21
Modified aie_runtime_lib/AIE2/lut_based_ops.cpp and lut_based_ops.h to use peano-friendly alignment for tanh LUTs, chess performance is unaffected.
aidansander
requested review from
stephenneuendorffer,
jgmelber,
fifield,
jackl-xilinx and
jsetoain
as code owners
jsetoain
approved these changes
Aug 27, 2024
Comment on lines
+84
to
+85
| alignas(aie::vector_decl_align) extern float tanh_lut_ab[128]; | ||
| alignas(aie::vector_decl_align) extern float tanh_lut_cd[128]; |
There was a problem hiding this comment.
Is there any benefit to having the alignment and size of these arrays declared here?
Comment on lines
+16
to
+17
|
|
||
|
|
There was a problem hiding this comment.
Nit.: too many blank lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a conversion pass similar to
ComputeTanhOpByLUTPatternbut targeting LLVMIR backend.