-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Enable init values for Object FIFO #1813
Draft
AndraBisca
wants to merge
17
commits into
main
Choose a base branch
from
objfifo-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+160
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st lock init values.
…o objfifo-init
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines
337
to
+338
auto prodLock = builder.create<LockOp>( | ||
builder.getUnknownLoc(), creation_tile, prodLockID, numElem); | ||
builder.getUnknownLoc(), creation_tile, prodLockID, numElem - initValues); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clang-format] reported by reviewdog 🐶
Suggested change
auto prodLock = builder.create<LockOp>( | |
builder.getUnknownLoc(), creation_tile, prodLockID, numElem); | |
builder.getUnknownLoc(), creation_tile, prodLockID, numElem - initValues); | |
auto prodLock = | |
builder.create<LockOp>(builder.getUnknownLoc(), creation_tile, | |
prodLockID, numElem - initValues); |
Comment on lines
346
to
+347
auto consLock = builder.create<LockOp>(builder.getUnknownLoc(), | ||
creation_tile, consLockID, 0); | ||
creation_tile, consLockID, initValues); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clang-format] reported by reviewdog 🐶
Suggested change
auto consLock = builder.create<LockOp>(builder.getUnknownLoc(), | |
creation_tile, consLockID, 0); | |
creation_tile, consLockID, initValues); | |
auto consLock = builder.create<LockOp>( | |
builder.getUnknownLoc(), creation_tile, consLockID, initValues); |
Coverage ReportCreated: 2024-10-30 20:51Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1801 to enable objectfifos to take as input an array of initial values.
Specifically:
AIE_LockOps
with init values such that the initialized objects will not be overwritten before they are communicated to the consumer(s).