-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repeat support for compute tiles #1842
Draft
AndraBisca
wants to merge
24
commits into
main
Choose a base branch
from
compute-tile-repeat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e DMAs from objectfifo repeatCount.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Coverage ReportCreated: 2024-10-30 11:26Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
… to see if I can see error in CI
…u-xrt/objectfifo_repeat); delete unused cmake files
hunhoffe
approved these changes
Oct 21, 2024
AndraBisca
requested review from
stephenneuendorffer,
jgmelber,
fifield and
jackl-xilinx
as code owners
October 21, 2024 18:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a repeat value can be specified for Mem tiles via the objectfifo's
memtile_repeat
attribute. This PR extends it to compute tiles as well.Specifically:
memtile_repeat
torepeat_count
,repeat_count
represents for objectfifos: a repeat of 'n' means 'n' total copies of that data will be transferred including the first one,repeat_count
attribute of the objectfifo is set, the objectfifo lowering will always use DMAs,repeat_count
attribute ofDMAStartOps
for Mem tiles: this is added for compute tiles,TODO: add documentation to programming guide