Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FXML-5060] Add instantiation arguments to xten_nn.kernel op #94

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

cferry-AMD
Copy link
Contributor

@cferry-AMD cferry-AMD commented Oct 2, 2024

This adds a new instantiation_args attribute to the xten_nn.kernel op, to represent instantiation arguments of templated kernels.
Optionally, the instantiation_arg_names attribute can be used to give names to the instantiation arguments. If there are names, then there must be as many names as arguments.

Instantiation arguments are integrated in the custom assembly as follows:

xten_nn.kernel "name" () instantiation_args ["N" = 42 : i32, "P" = 1 : i1]
xten_nn.kernel "name" () instantiation_args [42 : i32, 1 : i1]
xten_nn.kernel "name" () instantiation_args [2, 5]

@mgehre-amd mgehre-amd merged commit a08963c into feature/fused-ops Oct 4, 2024
2 checks passed
@mgehre-amd mgehre-amd deleted the corentin.kernel_template branch October 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants