Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: single frame/bulk refactor #75

Closed

Conversation

khanghugo
Copy link
Contributor

No description provided.

@khanghugo
Copy link
Contributor Author

This makes "mutate single frame bulk" to use "mutate frame bulk" so adding more stuffs doesn't need doing twice.

@khanghugo
Copy link
Contributor Author

I do see one difference is that it will not mutate if it is AutoMovement::SetYaw for mutate every single frame option. If that's worth it then I guess it can be changed.

@YaLTeR
Copy link
Owner

YaLTeR commented Jul 19, 2023

So the reason single frame mutation is separate is because it is a special case which can be handled more efficiently. Specifically, when mutating a single frame, the optimizer never picks yaw strafing, because within a single frame you can only go left or right. So if you pick yaw strafing then you will have the big yaw angle search space wasting the RNG attempts, instead of the much simpler binary left or right choice. Therefore I'm not sure it's a good idea to join these two cases like that.

@khanghugo
Copy link
Contributor Author

Thanks. Understandable.

@khanghugo khanghugo closed this Jul 19, 2023
@khanghugo khanghugo deleted the optimizer-mutate-single-refactor branch July 19, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants