Update chart js to 4.3.3 #5293
Merged
Update chart js to 4.3.3 #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon <simonsmith5521@gmail.com>
Signed-off-by: Simon <simonsmith5521@gmail.com>
Signed-off-by: Simon <simonsmith5521@gmail.com>
|
@Ylianst Do you have an eta when do you have time to review this? |
|
@Ylianst please review and merge this, we need this to get this the CVE out of the software and to prevent Virus-Scanners to quarantine this. I tried my best to help out here, but we are now waiting 3 weeks for you and we really need this fix in the software to actually use it. |
|
So sorry for the delay on this. I am going to give my phone number to @si458 so I can do security checking and accept this faster. I will be releasing a new version of MeshCentral tomorrow. |
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5275
this will update chartjs to 4.3.3, this now requires an adapter and moment.js
sadly we have lost the shadoweffect on the doughnuts
but i will work out how to add them back in the future