Fix/v4.1.1.compiler errors #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,9 +69,13 @@ struct co_observable_inc_awaiter | |||
| }; | |||
|
|
|||
| template<typename Source> | |||
| struct co_observable_iterator : public iterator<input_iterator_tag, typename Source::value_type> | |||
There was a problem hiding this comment.
std::iterator is deprecated in C++17
| @@ -470,6 +470,8 @@ struct print_function | |||
| OStream& os; | |||
| Delimit delimit; | |||
| print_function(OStream& os, Delimit d) : os(os), delimit(std::move(d)) {} | |||
| print_function(print_function const& o) = default; | |||
There was a problem hiding this comment.
This and below: spelling out the default constructors is needed because of custom (deleted) assignment
| @@ -713,8 +721,8 @@ namespace detail { | |||
|
|
|||
| template<class... T> | |||
| inline auto surely(const std::tuple<T...>& tpl) | |||
| -> decltype(apply(tpl, detail::surely())) { | |||
| return apply(tpl, detail::surely()); | |||
| -> decltype(util::apply(tpl, detail::surely {})) { | |||
There was a problem hiding this comment.
This is the important part: If a using namespace std sneaks in from somewhere, std::apply was used instead of util::apply.
|
Would it make sense to contribute these to the project directly instead of having a fork? |
It would, but to me it looks like RxCpp doesn't have any plans to do maintenance releases for 4.1 series or even read bug reports, and even the main development branch is half-abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to make the project buildable on up-to-date Xcode and Visual Studio and some small optimisations to allow move instead of copy and remove unnecessary enable_shared_from_this.