Skip to content

UN-3569 [FIX] Pass enable_header_mapping through agentic_params - #2268

Open
harini-venkataraman wants to merge 4 commits into
mainfrom
fix/enable-header-mapping-passthrough
Open

UN-3569 [FIX] Pass enable_header_mapping through agentic_params#2268
harini-venkataraman wants to merge 4 commits into
mainfrom
fix/enable-header-mapping-passthrough

Conversation

@harini-venkataraman

Copy link
Copy Markdown
Contributor

The cloud backend stores enable_header_mapping in tool_metadata["agentic_table_settings"], but structure_tool_task.py never forwarded it to the executor. The executor already reads params.get("enable_header_mapping", False), so this one-line addition closes the gap for API/ETL/workflow runs.

What

  • Forward the enable_header_mapping setting from agentic_table_settings into agentic_params in structure_tool_task.py

Why

  • The enable_header_mapping toggle stored in the DB was never passed through to the executor, making it inert for API/ETL/workflow runs despite being configurable in the cloud UI

How

  • Added "enable_header_mapping": at_settings.get("enable_header_mapping", False) to the agentic_params dict in _execute_structure_tool_impl(), alongside the existing group_key entry
  • The executor already reads params.get("enable_header_mapping", False), so no downstream changes are needed

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No. The default value is False, which matches the executor's existing default. Existing workflows that don't set this flag will behave identically.

Database Migrations

  • None

Env Config

  • None

Relevant Docs

  • N/A

Related Issues or PRs

  • UN-3569

Dependencies Versions

  • No dependency changes

Notes on Testing

  • Existing agentic_table tests pass (default False preserves backward compatibility)
  • Manual verification: enable the enable_header_mapping toggle in the cloud UI, run an agentic table extraction, and confirm header mapping is applied

Screenshots

  • N/A (backend-only change)

Checklist

The cloud backend stores enable_header_mapping in
tool_metadata["agentic_table_settings"], but structure_tool_task.py
never forwarded it to the executor. The executor already reads
params.get("enable_header_mapping", False), so this one-line addition
closes the gap for API/ETL/workflow runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR forwards the persisted enable_header_mapping agentic-table setting from the file-processing worker to the executor while preserving the existing False default.

  • Adds enable_header_mapping to the agentic executor parameter envelope.
  • Leaves workflows without the setting behaviorally unchanged.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
workers/file_processing/structure_tool_task.py Forwards the header-mapping toggle alongside the existing agentic-table execution parameters with a backward-compatible default.

Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/enable-head..." | Re-trigger Greptile

harini-venkataraman and others added 2 commits September 1, 2026 13:08
Signed-off-by: harini-venkataraman <115449948+harini-venkataraman@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Unstract test results

Per-group results

Status Group Tier Passed Failed Errors Skipped Duration (s)
e2e-api-deployment e2e 3 0 0 0 22.1
e2e-coowners e2e 1 0 0 0 1.1
e2e-etl e2e 1 0 0 0 8.2
e2e-login e2e 2 0 0 0 0.8
e2e-prompt-studio e2e 1 0 0 0 4.3
e2e-smoke e2e 2 0 0 0 0.8
e2e-workflow e2e 1 0 0 0 15.9
frontend unit 0 1 0 0 0.0
integration-backend integration 310 0 0 26 44.8
integration-connectors integration 1 0 0 7 8.0
integration-workers integration 157 0 0 1 49.6
ui e2e 0 1 0 0 0.0
unit-backend unit 1158 0 0 1 41.6
unit-connectors unit 63 0 0 0 9.9
unit-core unit 33 0 0 0 1.3
unit-platform-service unit 15 0 0 0 2.6
unit-rig unit 120 0 0 0 4.6
unit-runner unit 5 0 0 0 2.9
unit-sdk1 unit 563 0 0 0 29.1
unit-workers unit 1397 0 0 1 128.2
TOTAL 3833 2 0 36 375.9

Critical paths

⚠️ Critical paths not yet covered

  • workflow-execution-fan-out — Multi-file workflow execution fans out to file-processing workers and rejoins. (declared coverage: no groups declared)
✅ Covered critical paths
  • auth-login — covered by e2e-login
  • adapter-register-llm — covered by integration-backend
  • workflow-author — covered by integration-backend
  • co-owner-manage — covered by integration-backend, e2e-coowners
  • workflow-create-execute — covered by e2e-workflow
  • api-deployment-provision — covered by integration-backend
  • api-deployment-auth — covered by integration-backend
  • api-deployment-run — covered by e2e-api-deployment
  • mcp-server-auth — covered by integration-backend
  • mcp-platform-auth — covered by integration-backend
  • prompt-studio-author — covered by integration-backend
  • prompt-studio-fetch-response — covered by e2e-prompt-studio
  • connector-register-test — covered by integration-backend
  • pipeline-etl-execute — covered by e2e-etl
  • usage-aggregate-read — covered by integration-backend
  • usage-token-tracking — covered by e2e-api-deployment
  • callback-result-delivery — covered by e2e-api-deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants